Fix #780: improve fixed rate scheduling on JS #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #790 +/- ##
==========================================
+ Coverage 90.38% 90.48% +0.09%
==========================================
Files 426 426
Lines 12308 12308
Branches 2264 2264
==========================================
+ Hits 11125 11137 +12
+ Misses 1183 1171 -12 |
|
It's pretty good. Another idea would be to have a start time and then schedule at Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple fix that seems to give most consistency. The idea is basically to add scheduling lag time to task execution time. Test is a bit non-deterministic (and I don't know how Travis would accept these), but change seems to reduce the accumulated error by a factor of magnitude in this simple scenario.